Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename invoke generator #456

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

giladchase
Copy link
Collaborator

@giladchase giladchase commented Jul 11, 2024

This change is Reviewable

@giladchase giladchase force-pushed the gilad/rename-generate-default branch from ffd131d to 52b1741 Compare July 11, 2024 14:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.89%. Comparing base (7c08d83) to head (d4a0080).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files          37       37           
  Lines        1719     1719           
  Branches     1719     1719           
=======================================
  Hits         1425     1425           
  Misses        217      217           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

deploy support is coming soon
@giladchase giladchase force-pushed the gilad/rename-generate-default branch from 52b1741 to d4a0080 Compare July 11, 2024 15:08
@giladchase giladchase changed the title Gilad/rename generate default refactor: rename invoke generator Jul 11, 2024
Copy link
Collaborator Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@giladchase giladchase merged commit 528d350 into main Jul 11, 2024
12 of 13 checks passed
@giladchase giladchase deleted the gilad/rename-generate-default branch July 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants